No closing semicolon, anyone got any extras to throw on this thing?
this post was submitted on 09 Dec 2023
1097 points (97.5% liked)
Programmer Humor
19165 readers
1433 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
; found this in the back for you should still work though
Can confirm.
At the very least I'd try to clean up that fuzzy condition on behavior to anticipate any bad or inconsistent data entry.
WHERE UPPER(TRIM(behavior)) = 'NICE'
Depending on the possible values in behavior, adding a wildcard or two might be useful but would need to know more about that field to be certain. Personally I'd rather see if there was a methodology using code values or existing indicators instead of a string, but that's often just wishful thinking.
Edit: Also, why dafuq we doing a select all? What is this, intro to compsci? List out the values you need, ya heathen ;)
(This is my favorite Xmas meme lol)
behavior is an ENUM.
That’s a table scan, right there. Naughty.
Need to normalize the database. I would add a join to a BehaviorTypes table.
Edit: or, if the only options are naughty or nice, make it a boolean.
Honest question, which ones wouldn't it work with? Most add a semicolon to the end automatically or have libraries and interfaces saved me a million times?
Other reply s accurate but it's always a good practice to include the semicolon else you can get
"Bobby tables'ed" look that xkcd comic up
I'm not sure how including a final semicolon can protect against an injection attack. In fact, the "Bobby Tables" attack specifically adds in a semicolon, to be able to start a new command. If inputs are sanitized, or much better, passed as parameters rather than string concatenated, you should be fine - nothing can be injected, regardless of the semicolon. If you concatenate untrusted strings straight into your query, an injection can be crafted to take advantage, with or without a semicolon.
Yep it would only work if you didn't sanitize a user input string in this case 'nice'
They could write ''; drop table blah;
load more comments
(1 replies)
load more comments
(1 replies)
You need semicolons if it is a script with multiple commands to separate them. It is not needed for a single statement, like you would use in most language libraries.
load more comments
(2 replies)
Can we get a SIMILARITY?
That SELECT and WHERE are all caps, but from is not is bugging me.
I don't care if you choose to uppercase keywords or lowercase, but consistency please.
Also, great, love it.
it also implies that naughty or nice is an either or thing and not a weighted thing from an incidents table. the good place lied to us.
It could be a materialized view that is generated off of a weighting where you are nice until you have a certain number of incidents.
Guess that settles the debate, we got to pronounce it "sequel" then to optimally match syllables
Uuugghhh noooo! Ess Kyoo Ell!! ESS KYOO ELL!!! brandishes flaming pitchfork!
Squirrel works too though.
The Australian pronunciation works… “squi-rell”. Common American one is somehow just one syllable, “Skwurl”
load more comments
(2 replies)
Yes but he serves a different community
!squirrels@lemmy.ca
Sequel to what?
load more comments
(8 replies)
dammit bobby tables is on the naughty list again
I can't be the only one disappointed by the lack of an order by clause after being told the list was being sorted (twice!)...
Can anyone recommend a cheap receipt printer that takes pictures from a pc or phone? I want to print mtg tokens on the fly.
Gameboy Pocket. Gameboy Camera. Gameboy Printer.
Both the perfect balance of “nostalgia” and “ridiculous”.
Pencil
He sees you when you’re bashing
He’s hacked your VPN
He knows you're not in the sudoers file
So he'll report your ass again
I'll be damned if that's not the most relevant xkcd that I've ever seen.
I was reading that to the tune of the chorus of The Distance by Cake. It worked until the last line.
The beginning maps perfectly to "The Distance" by Cake and I was singing along to that tune as I read.
Cut to Mrs Claus baking a spice cake:
She's all alone, all alone, in her time of spice
Love it keep em coming
I started this in my head sounding like the singer from Cake.
view more: next ›