this post was submitted on 31 Oct 2024
387 points (98.5% liked)

196

16746 readers
2549 users here now

Be sure to follow the rule before you head out.

Rule: You must post before you leave.

^other^ ^rules^

founded 2 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] FiskFisk33@startrek.website 14 points 1 month ago (4 children)

oh of course there is

https://www.npmjs.com/package/is-even

(do take a look at the download stats)

[–] FJW@discuss.tchncs.de 12 points 1 month ago* (last edited 1 month ago)

And that isn’t even the worst thing about it…

The implementation looks like this:

function isEven(i) {
  return !isOdd(i);
};

And yes, is-odd is a dependency that in turn depends on is-number

[–] Micromot@feddit.org 7 points 1 month ago* (last edited 1 month ago) (4 children)

Can't you just

If (number % 2 == 0){return true}

[–] blackn1ght@feddit.uk 12 points 1 month ago (1 children)
[–] Micromot@feddit.org 1 points 1 month ago

Yeah, that's even simpler

[–] drake@lemmy.sdf.org 6 points 1 month ago (2 children)

but what if number isn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate that number is actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.

That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.

[–] Micromot@feddit.org 1 points 1 month ago (1 children)

That would already cause an exception when calling the function because it has int number in the parameters

[–] drake@lemmy.sdf.org 4 points 1 month ago

Javascript doesn’t have strongly-typed variables

[–] FiskFisk33@startrek.website 1 points 1 month ago

ah the joys of loosely typed languages

[–] FiskFisk33@startrek.website 5 points 1 month ago

yup, which is why I find the download stats truly horrifying

[–] servobobo@feddit.nl 7 points 1 month ago* (last edited 1 month ago)

"If it's not an npm package it's impossible"

- JS devs, probably

[–] tb_@lemmy.world 5 points 1 month ago

That's a lot of downloads