this post was submitted on 25 Feb 2024
17 points (100.0% liked)

Programming

13376 readers
10 users here now

All things programming and coding related. Subcommunity of Technology.


This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.

founded 1 year ago
MODERATORS
 

Think of a similar scope of change to a large codebase you're familiar with, for frame of reference.

top 2 comments
sorted by: hot top controversial new old
[–] TheOctonaut@mander.xyz 8 points 8 months ago (1 children)

Little bit unfair as this was already an existing thing that got a new way to be triggered rather than a completely new feature needing code to handle not following symlinks.

To accurately guess you'd need to know that "don't follow symlinks in this particular scenario" already exists and we're just adding an OR to an if statement.

[–] mozz@mbin.grits.dev 4 points 8 months ago* (last edited 8 months ago)

You have misunderstood. No, it wasn't an existing thing. This is the code that implements it. That's the point.

The change to fs/namei.c is the code to handle not following symlinks; the rest is some necessary code to create the option and expose it to userland.

(Edit: Rereading I do see a little better what you were saying - I actually looked it up and the code that “originally” implemented not following symlinks, that you’re saying we're now adding an or statement to activate, was 2 lines to expose the option, 2 lines of white space, and 2 lines to implement not following symlinks).