Fedia Discussions

1 readers

1 users here now

founded 1 year ago

MODERATORS

jerry@fedia.io

What happened to embedded videos? (fedia.io)

submitted 8 months ago by DarkThoughts@fedia.io to c/fedia@fedia.io

5 comments fedilink hide all child comments

For a while now all video threads are basically just opening a screenshot of the video when you expand them instead of opening the video itself. I noticed this both for YouTube and Catbox hosted videos and you now have to first open the thread itself, and then click on the actual link of the title to open the actual page where it is hosted to play the video. Previously you could just watch them from within your feed without leaving it.

I think the only exception I've seen for this are redgifs that sometimes pop up from the few lemmynsfw places that do manage to federate with kbin / mbin, but those also have issues like rendering behind the posts below them.

I also noticed that video playback does continue when you close the embedded container, so you always have to pause them manually (which is ironically not supported by redgifs player).

all 7 comments

sorted by: hot top controversial new old

[–] e-five@fedia.io 2 points 8 months ago (1 children)

I think at least the first part of this is https://github.com/MbinOrg/mbin/pull/561

It was fixed a couple weeks ago but there hasn't been a tagged release in a while.

I'm not sure what the release plan is for 1.5.0, currently there's some very heavy migrations that require special upgrade instructions so I'd like to get a tagged release sooner rather than later to avoid instance admins running into issues, but I think there's still a lot of work in flight

[–] DarkThoughts@fedia.io 1 points 8 months ago (2 children)

I just noticed that the overlap issue also happens with pictures apparently , or at least those thumbnail screenshot from videos. Unless you hover over the image (or redgif video), then it hovers into the foreground.

[–] e-five@fedia.io 1 points 8 months ago (1 children)

Oh do you use compact mode? If so, sadly another thing that was fixed a while back that hopefully will be fixed for you next release https://github.com/MbinOrg/mbin/pull/544

[–] DarkThoughts@fedia.io 1 points 8 months ago (1 children)

Yes. The default view just adds a lot of wasted empty space, useless icons and even more useless cut-off text previews which I don't see the point of.

Doesn't quite look like the same issue, but I trust your word that it got fixed and hope for the next release then.

[–] e-five@fedia.io 1 points 8 months ago* (last edited 8 months ago)

The post you showed in the screenshot does look fine to me both in classic and compact view on an instance with latest.

But I'd agree not all of your concerns have been addressed. I don't believe redgifs work (well), so will try to look into that if possible, but might be out of my depth.

The playback continuing is interesting. I had made a change long ago to not download every time it was expanded / collapsed as before it would make a request every single time, instead I changed it to just hide and show it after the first load, so that sounds like a side effect of that. Perhaps there's some way for me to also indicate to pause media, I will check