this post was submitted on 24 Dec 2024
44 points (97.8% liked)

Open Source

31734 readers
215 users here now

All about open source! Feel free to ask questions, and share news, and interesting stuff!

Useful Links

Rules

Related Communities

Community icon from opensource.org, but we are not affiliated with them.

founded 5 years ago
MODERATORS
 

I've forked an app I use myself to add what I thought would be a (relatively) small fix. I then realised it was sort of left in the middle of a redesign/rewrite caused by dependency updates changing / breaking things and decided I needed to finish that if I wanted to see my code on a release. Along the way I got carried away and now the fork feels too large to pull request.

The changes I made don't meaningfully change the app structure but they required multiple refactorings/rewrites and extrapolation of what the redesign was trying to do.

The original developer is active but haven't committed to the repo in a long time. What should I do? I just want people to use the code I wrote. Do I PR and see what they say? Do I make another branch of its main and try to add my changes in more digestible chunks? Do I change the package name and release a build myself? I don't want to figure out a new name / logo etc, especially since the app is largely the same.

There are issues on the original repo about bugs I fixed. I'd like to point them to my fork, but that feels like shilling an unnecessarily made fork. And it doesn't feel right to drop a huge PR on the dev and expect them to accept it or even reply neither.

What do?

you are viewing a single comment's thread
view the rest of the comments
[–] AnyOldName3@lemmy.world 4 points 1 day ago

Like other commenters have said, start by asking the upstream developer (whether that's by sending a message with a link to the fork or by sending a mega-PR that says you don't expect it to be merged as-is in the description). They should be the best judge of how they'd prefer to handle it. The thing I'd add is that you should try to avoid taking it personally if their preferred approach isn't one you think is a good idea. Sometimes good fixes end up never merged because of disagreements becoming too heated even if everyone's basically on the same page about the fox being good. There's also a decent chance that your refactors are things the upstream developer explicitly doesn't want and would otherwise have done them themselves and implemented the same fix, too, or they don't agree that your fix is good enough. They won't want to be on the hook for maintaining contributions that use approaches and code style that they don't like, and that's okay. They also might know something you don't about their project that would make something that's obviously a good idea to you obviously a bad idea to them.

Basically, just try and remember that if it's a hobby project, it makes progress when the maintainer is having a good time, and gets abandoned when they're not anymore, so try and avoid making a mess and having arguments when they're the one that'll have to deal with any fallout from any mistakes.