this post was submitted on 10 Aug 2024
142 points (94.9% liked)

Programming

17423 readers
90 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev

founded 1 year ago
MODERATORS
snowe@programming.dev
Ategon@programming.dev
MaungaHikoi@lemmy.nz
142
It's probably time to stop recommending Clean Code @ Things Of Interest (qntm.org)
submitted 3 months ago by JackbyDev@programming.dev to c/programming@programming.dev
69 comments fedilink hide all child comments
 

Seeing that Uncle Bob is making a new version of Clean Code I decided to try and find this article about the original.

you are viewing a single comment's thread
view the rest of the comments
[–] realharo@lemm.ee 13 points 3 months ago* (last edited 3 months ago) (1 children)

It's not nitpicking, stuff like this is far more impactful than choosing between 5 lines vs 10 lines long methods, or whether the hasExtraCommissions "if" belongs inside or outside of calculateExtraCommissions. This kind of thing should immediately jump out at you as a red flag when you're reading code, it's not something to handwave away as a detail.

[–] dandi8@fedia.io -5 points 3 months ago (1 children)

I never claimed it's not important, I'm just saying it's not relevant here, as there is no context to where this method was put in the code.

As I said, it might be top-level. You have to mutate state somewhere, because that's what applications ultimately do. You just don't want state mutations everywhere, because that makes bad code.

[–] BatmanAoD@programming.dev 9 points 3 months ago

The whole book is like this, though, and these are specifically supposed to be examples of "good" code. The rewritten time class toward the end, a fully rewritten Java module, is a nightmare by the time Martin finishes with it. And I'm pretty sure it has a bug, though I couldn't be bothered to type the whole thing into an editor to test it myself.