this post was submitted on 29 Mar 2024
887 points (98.4% liked)

Programmer Humor

19166 readers
890 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
887
Review Please (programming.dev)
submitted 5 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
100 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[โ€“] Jesus_666@feddit.de 25 points 5 months ago (1 children)

Or, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps.

If that's not how you worked on the change than you either rewrite the history to make it look like you did or you'll have to start over.

[โ€“] BrianTheeBiscuiteer@lemmy.world 2 points 5 months ago

Very good point. We often do one PR per story so people tend to think that's a limit.