perhaps we should introduce the PR Wall of Shame for exactly those situations. I mean, obviously you don't want to strangle productivity by naming and shaming people for every single small mistake, but such egregious violations like not even click testing the happy path should be used as an example of what fucking up looks like

[–] tatterdemalion@programming.dev 4 points 1 year ago (1 children)

Playing the blame game, especially publicly, is a bad way to encourage psychological safety in a community. See Linus Torvalds for examples (he has recently become a bit softer with his feedback).

A better option is to make clear expectations of what a good PR looks like. Then if expectations are not met, you can give 1 on 1 feedback. Don't just blast a noob in public or you can leave emotional scars.

[–] fiah@discuss.tchncs.de 2 points 1 year ago

Don’t just blast a noob in public

true, but also when someone who's been around for a while and ought to know better, it can really help to remind them that they're not above the rules