this post was submitted on 04 Mar 2024
335 points (100.0% liked)
196
16511 readers
2532 users here now
Be sure to follow the rule before you head out.
Rule: You must post before you leave.
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
If else to return true or false? I think I need a shower after reading that code
I’m even more disturbed by the try catch that will never catch anyway. Most disturbing is the absolute heresy that is the throw within the catch. …is vibe even defined here??? I think I need to reconsider my major.
Catching and rethrowing just to log the error is a valid use of a try catch IMO
If you don't care anything about performance, absolutely
My personal take on this, at least when dealing with more complex or production code:
Performance is not an issue with exceptions if you don't use them for control flow, they should be an unusual occurrence wherever possible.
If you expect to throw and later handle an exception regularly, I'd try to include relevant info about the failure in the returned value, or even better in the returned type, and skip throwing the exception altogether.
Returning a type that contains both error info and the actual result (if there is one) and forces the caller of your function to handle any contained error info before being able to access the actual result has the same effect as a try/catch block without the major performance implications.
This is basically what rust does everywhere in order to completely remove the concept of exceptions, but it's a nice performance optimization for langues with exceptions as well.
Exceptions should interrupt your programs flow, not control it, at least in all hot execution paths. Thanks for coming to my ted talk
Performance isn't an issue if you don't care about performance, correct.
Kind of a knee-jerk reaction to it on my part, plus I’ve got personal bias against exceptions (errors as values my beloved). The worst thing is that thinking about this code has managed to take time I could’ve used being non-productive with my own projects smh.