this post was submitted on 07 Dec 2023
178 points (90.8% liked)

Programming Horror

1833 readers
1 users here now

Welcome to Programming Horror!

This is a place to share strange or terrible code you come across.

For more general memes about programming there's also Programmer Humor.

Looking for mods. If youre interested in moderating the community feel free to dm @Ategon@programming.dev

Rules

Credits

founded 1 year ago
MODERATORS
Vacant@programming.dev
178
God I wish there was an easier way to do this (programming.dev)
submitted 9 months ago* (last edited 9 months ago) by andioop@programming.dev to c/programming_horror@programming.dev
54 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] noddy@beehaw.org 21 points 9 months ago* (last edited 9 months ago) (1 children)

I know how to fix this!

bool IsEven(int number) {
    bool even = true;
    for (int i = 0; i < number; ++i) {
        if (even == true) {
            even = false;
        }
        else if (even == false) {
            even = true;
        }
        else {
            throw RuntimeException("Could not determine whether even is true or false.");
        }
    }

    if (even == true) {
        return even ? true : false;
    }
    else if (even == false) {
        return (!even) ? false : true;
    }
    else {
        throw RuntimeException("Could not determine whether even is true or false.");
    }
}
[–] odium@programming.dev 7 points 9 months ago (1 children)

Have you tried seeing if the recursive approach runs faster?

[–] noddy@beehaw.org 11 points 9 months ago

I know an even better way. We can make it run in O(1) by using a lookup table. We only need to store 2^64 booleans in an array first.