this post was submitted on 07 Jun 2023
147 points (98.7% liked)
Lemmy
12524 readers
100 users here now
Everything about Lemmy; bugs, gripes, praises, and advocacy.
For discussion about the lemmy.ml instance, go to !meta@lemmy.ml.
founded 4 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
You thinking just a with the 4 links in it and a header of some sort? Mock or description or anything?
I think at the top, just above the "Recommended" add:
Not sure who the approved reviewers are.
https://github.com/LemmyNet/joinlemmy-translations/pull/12 <-- translations PR, prerequisite of other PR
https://github.com/LemmyNet/joinlemmy-site/pull/158 <-- DRAFT PR. This one will need the translations folder updated after the translations PR is done. There might be a better way to do this, but I almost never work on submodules in this way.
That's @nutomic@lemmy.ml
Translation merged. Actual HTML in full PR. Once/if @nutomic@lemmy.ml approves, we'll be.... Nevermind, he just approved it. He said it'll be live in an hour or two.
There wasn't really anything that resembled typescript changes ultimately. The submoduled translations were the only real time sink there.
Awesome, thank you! 🚀
I see these changes, but I don't understand how the i18n stuff works
Where's the file/commit for the actual text stored for
instance_comparison
andinstance_browser
?Took me a little while, too. The i18n stuff is all in the translations repo (which is why I needed to PR that one, too and first). You won't find it anywhere in the active repo (I think this is a flaw, and the joinlemmy translation stuff at least should be in the same repo. But the idea makes sense to not repeat translations that show up in other projects)
On build-run, the translation process runs, which seems to "guess" any lines in non-english that it discovers. I didn't dig too deeply, but it wasn't immediately obvious how it knew to check English for the originals, only that English has no retranslation tool attached to it.
Ok, thanks. I see the i18n text changes were here:
18n is probably good, but it does really make it harder for folks to collaborate. It totally stopped me from contributing. Thank you for your help <3
Yeah. It's super-important to have, and nothing is simpler for what it does, but that doesn't make it simple itself.
Of course, trying to translate in-flight with English HTML would be worse.
:+1