this post was submitted on 20 Jul 2023
761 points (96.6% liked)
Linux
48033 readers
1194 users here now
From Wikipedia, the free encyclopedia
Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).
Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.
Rules
- Posts must be relevant to operating systems running the Linux kernel. GNU/Linux or otherwise.
- No misinformation
- No NSFW content
- No hate speech, bigotry, etc
Related Communities
Community icon by Alpár-Etele Méder, licensed under CC BY 3.0
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
It still requires a substantial amount of time to review the fix. Depending on the circumstances it might require more time to review a piece of code than to write it.
For large scale patches: definitely. It's often easier for a project to let its own experts write their own 100 line patch than it is to review someone else's 100 line patch.
In this instance: it's a changelog entry and a patch to a C file (8 insertions(+), 1 deletion(-)). Remove the printed warning and you're back to 5 insertions. Furthermore, the patch has already been merged upstream.
Redhat is free to choose what patches they do and do not accept and the low quality Reddit outrage posts in the Gitlab issue sure doesn't make things any better, but this is quite a silly thing to refuse to merge.
A patch contains more than the changes: it contains the commit message. In open source projects, and in particular in CVE fixes, the commit message can indeed be quite descriptive. It needs to be!
You're still right, though. But I like to think professionals are able to verify the changes with the high-quality commit message—possibly in less time than investigating the issue themselves.
How did they submit changes to only one file? Did they not write a test for it? Sounds like a dodgy patch if it doesn't have a test
The project's tests aren't exactly exhaustive.I don't think anyone expected them to add any tests.