Lemmy Support

4652 readers

1 users here now

Support / questions about Lemmy.

Matrix Space: #lemmy-space

founded 5 years ago

MODERATORS

dessalines@lemmy.ml

0.19.5: edits to community sidebar mangle shields.io-linked badges (midwest.social)

submitted 4 months ago by raoulraoul@midwest.social to c/lemmy_support@lemmy.ml

7 comments fedilink hide all child comments

Over at !music@midwest.social we've got a sidebar with a "total subscribers" shields.io badge, like many other communities all over the Lemmyverse do. I made a simple, non-badge-related edit to the sidebar and due to what seems an aggressive image proxy, the shields.io badge address gets mangled after the edit is saved.

This is "Community Info" from !music@midwest.social on Jerboa. At the bottom of the screen is the midwest.social/api/v3/image_proxy image.

This is "Community Info" from !detroit@midwest.social on Jerboa, as an example of a working badge. At the bottom the screen is the working shields.io badge.

The pre-save preview shows everything as should be. It's only when the edit is saved does the badge address get mangled.

I contacted our fearless leader, @seahorse@midwest.social, and he changed an image proxy setting. Now !music@midwest.social works as it should. Any further details or information in regards should be asked of him. Thanks.

Workers of The World...Relax!
!detroit@midwest.social ☆ !michigan@midwest.social ☆ !music@midwest.social

top 7 comments

sorted by: hot top controversial new old

[–] Max_P@lemmy.max-p.me 5 points 4 months ago (1 children)

Ask your admin to turn it off, or if you're the admin, turn it off.

They really went with the worst possible way to implement this in that it mangles the post to rewrite all images to the image proxy, so it's not giving you a choice. So if you want the original link you have to reprocess it to strip the proxy. It's like when they thought it was a good idea to store the data as HTML encoded, so not-web clients had to try to undo all of it and it's lossy. It should be up to the clients to add the proxy as needed and if desired. Never mangle user data for storage, always reprocess it as needed and cache it if the processing is expensive.

Now you edit a post and your links are rewritten to the proxy, and if you save it again, now you proxy to the proxy. Just like when they applied the HTML processing on save, if you edited a post and saved it again it would become double encoded.

Personally I leave it off, and let Tesseract do it instead when it renders the images. It's the right way to do it. If the user wants a fresh copy because it's a dynamic image, they can do so on demand instead of being forced into it. And it actually works retroactively compared to the Lemmy server only doing it for new posts.

[–] raoulraoul@midwest.social 1 points 4 months ago

Ask your admin to turn it off

Thanks, I believe that's exactly what he did.

[–] Die4Ever@programming.dev 2 points 4 months ago (2 children)

Semi off topic, but isn't the subscriber count badge useless now since Lemmy fixed their reporting of that?

[–] otter@lemmy.ca 2 points 4 months ago (1 children)

Yea it's a bit redundant now

I've still kept mine up, along with the post explaining it, because I think they look nice in the sidebar. I haven't added them to any new communities however

[–] Blaze@sopuli.xyz 1 points 4 months ago

Same here

[–] raoulraoul@midwest.social 1 points 4 months ago (1 children)

isn’t the subscriber count badge useless now since Lemmy fixed their reporting of that?

You're not wrong but "fixed" is a subjective term in this case. Two of the largest instances, https://lemmy.world and https://sh.itjust.works, have yet to "upgrade" past 0.19.3, like many other instances that prefer not to be on the cutting-edge. Nevertheless, the linked shield.io badges may also give other information and not strictly the soon-to-be-redundant "total subscribers" badge.

Stay sick, scratch glass, turn blue, climb walls…but don't get caught!
!detroit@midwest.social ☆ !michigan@midwest.social ☆ !music@midwest.social

[–] Blaze@sopuli.xyz 1 points 4 months ago

Hasn't the subscribers count been fixed in version 0.19.3 itself?