this post was submitted on 15 Jun 2023
4 points (100.0% liked)

Lemmy

12538 readers
8 users here now

Everything about Lemmy; bugs, gripes, praises, and advocacy.

For discussion about the lemmy.ml instance, go to !meta@lemmy.ml.

founded 4 years ago
MODERATORS
nutomic@lemmy.ml
4
Lemmy hotfix for home page bugs... (halubilo.social)
submitted 1 year ago by jcg@halubilo.social to c/lemmy@lemmy.ml
6 comments fedilink hide all child comments
 

Hey guys, as I'm sure many of you are already aware there's a couple of bugs that are plaguing the home page. I've made a hotfix for these bugs:

  1. New posts popping up and pushing all the other posts downwards - this is more prevalent on the larger lemmy instances, you'll just be scrolling and suddenly everything's pushed down because new posts are being added to the top of the page as they're being created
  2. Default "All" not working - this is more something admins would be aware of but in the site settings you can set the default "Listing Type" to "All" instead of "Local", but if you do this the home page doesn't properly load "All", it'll show you the "Local" feed with "All" selected in the tabs. Seems this feature wasn't implemented correctly in time for 0.17.4

Since 0.18 is still a little while out, and I'm sure the devs are both really busy on it (they also said they won't be making another 0.17 release), I went ahead and made a hotfix for these. I have it up on jcgurango/lemmy-ui:0.17.4-hotfix so if you're using docker you can just upgrade to that image. I'm not really sure how ansible works, so I can't help with that.

Here's the repo I have these changes on for those who want to check or build it themselves: https://github.com/jcgurango/lemmy-ui - I've based it on the v0.17.4 tag on the upstream repo.

top 6 comments
sorted by: hot top controversial new old
[–] cetra3@lemmy.ml 0 points 1 year ago (1 children)

Would this be good as a PR?

[–] jcg@halubilo.social 2 points 1 year ago (1 children)

I read in one of the PRs they aren't doing another 0.17 release, and the first issue is already fixed in 0.18 since they're removing the WS client

[–] MyNameIsRichard@lemmy.ml 0 points 1 year ago (1 children)

What does WS mean? I hope it's not Web Site

[–] jcg@halubilo.social 2 points 1 year ago (2 children)

It means websockets, they way it's implemented throughout the website has been a cause of a lot of headaches and they were using it for things where it really wasn't needed. My hunch is it was to lessen the bandwidth usage but I wonder if that's actually worked out.

[–] MyNameIsRichard@lemmy.ml 1 points 1 year ago

Things that are obvious in retrospect! I saw WS and my brain went straight to web site 😆 and I couldn't think of anything else.

[–] UrbenLegend@lemmy.ml 1 points 1 year ago

My hunch is it was to lessen the bandwidth usage

WS is probably more resource intensive than regular HTTP because it requires an active connection, whereas HTTP creates a connection and then tears it down. Devs have said they're removing WS to reduce load on the server.