this post was submitted on 29 Mar 2024
888 points (98.4% liked)

Programmer Humor

19315 readers
2 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
888
Review Please (programming.dev)
submitted 6 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
100 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] dan@upvote.au 4 points 6 months ago (2 children)

I try to keep my changes under 300-350 lines. Seems like a good threshold.

I'm still annoyed that Github doesn't have good support for stacked diffs. It's still not possible to say that one PR depends on a different one, and still has no ability to review and land them as a stack.

[–] iknowitwheniseeit@lemmynsfw.com 2 points 6 months ago (1 children)

How is this different from creating a feature branch and making your PR against them until everything is done, then merging that into the main branch?

[–] nomen_dubium@startrek.website 1 points 6 months ago

also iirc gitlab does offer something like this as a feature now with "merge trains" (though i've never really used it, usualy just go for the feature branch out of habit x) )