this post was submitted on 25 Jun 2023
306 points (98.1% liked)
Programmer Humor
32480 readers
274 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
More often than not this is "it seems like there are problems with how it's implemented but I can't think of them now" but sometimes it definitely is "that's not the way I would have done it and therefore wrong"
All that said, I used to work with a guy that would find a reason to fail every code review. It became common for people to add intentional easy mistakes so that the lead could feel like he was contributing.
Oof, so counterproductive. I'm a hard reviewer, always try to hold others to the standard of code I'd like to work in, and be held to myself, but every once in a while I see a PR that's just... no changes required.
I love just hitting accept without making any feedback, it means my coworker valued my feedback and actually internalized it. Trying to laser in and nitpick something unnecessary would be a waste of all our time.